office X2: expose bounded XLSX outline/get/text/query#172
Merged
Conversation
bobzhang
marked this pull request as ready for review
July 19, 2026 11:01
bobzhang
added a commit
that referenced
this pull request
Jul 19, 2026
PR #172 switched drawing hyperlink resolution to parse_external_relationship_targets only, so internal-mode hyperlink relationships - which this library's own writer emits for location links like "Sheet1!B2" - were dropped on read: the picture came back with an empty hyperlink and HyperlinkType::Unset. The regression was caught on main by the #177 round-trip test (merged concurrently, so neither PR's CI saw the interaction). Resolve both modes: external-mode targets keep HyperlinkType::External; a miss falls back to internal-mode targets as HyperlinkType::Location. Fixes the main-branch CI failure in xlsx/drawing_readback_roundtrip_test.mbt on native and wasm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
What changed
office outline|get|text|queryacross validated DOCX and XLSX packages<Default>Why
The canonical Office CLI previously exposed structured DOCX reads but did not provide equivalent bounded XLSX outline/get/text/query behavior. This closes that read-only parity gap while keeping one validated archive, deterministic selectors, explicit resource ceilings, and native/Wasm behavior.
Validation
moon check --target nativemoon check --target wasmmoon test --target native: 4912/4912moon test --target wasm: 4259/4259moon info && moon fmtgit diff --checkReview gate
A fresh ephemeral
gpt-5.6-solUltra review (session019f6e62-fd62-7630-acd0-69a7478d98dd) found two P2 issues: unquoted 3-D shared-formula qualifiers and default-declared relocated workbook paths. Both are fixed in8329a5abwith direct native/Wasm regressions.A required brand-new post-fix review was attempted at Ultra (session
019f6ea5-7034-73f0-bca7-eaad02ae0385) and Max (session019f6ea5-c0b5-7281-a974-028b3d68508b), but the Codex account rejected both before review due to its usage limit. Keep this PR in draft and do not merge until a fresh post-fix Codex CLI review completes cleanly.